----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review81225 -----------------------------------------------------------
LGTM Thanks! It's also used by the wallpaper config. I guess the IconButton used by Kickoff and folderview could also be moved to KQC src/qmlcontrols/kquickcontrols/ColorButton.qml (line 42) <https://git.reviewboard.kde.org/r/124014/#comment55622> _buttonMargins * 2 Same below src/qmlcontrols/kquickcontrols/ColorButton.qml (line 54) <https://git.reviewboard.kde.org/r/124014/#comment55623> You probably want to add an alias for the showAlphaChannel, title, and currentColor properties? - Kai Uwe Broulik On Juni 5, 2015, 10:46 vorm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124014/ > ----------------------------------------------------------- > > (Updated Juni 5, 2015, 10:46 vorm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Add QQC clone of KColorButton. > > It's being used by SystemLoadViewer Plasmoid, Kai's clock review, and a mod > I'm doing for the notes plasmoid and it's something we'll want to have. > > High DPI support works perfectly as these are device independent pixels. > > > Diffs > ----- > > src/qmlcontrols/kquickcontrols/CMakeLists.txt > b7c08d7bcb46e53407d4b44fa593346f9d0a2137 > src/qmlcontrols/kquickcontrols/ColorButton.qml PRE-CREATION > src/qmlcontrols/kquickcontrols/qmldir > 31d8b145bf50491f94a14ba317b215fd6cc0ca32 > tests/colorButtonTest.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124014/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
