-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123877/
-----------------------------------------------------------

Review request for Plasma.


Bugs: 348072
    https://bugs.kde.org/show_bug.cgi?id=348072


Repository: plasma-workspace


Description
-------

This restores the custom font family and font color options; also clean ups the 
layout a bit - we don't have a FormLayout, so that's the best it can get. Did I 
mention dealing with ComboBox is horrible?


Diffs
-----

  applets/digital-clock/package/contents/config/main.xml 5237160 
  applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 
  applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc 

Diff: https://git.reviewboard.kde.org/r/123877/diff/


Testing
-------

Checking and unchecking the custom color checkbox properly sets/unsets the 
color, the "Default" font option restores the default font, options in the 
dialog are properly restored when it opens, Apply button does not appear to 
have become broken.


File Attachments
----------------

The clock
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png
Settings
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png


Thanks,

Kai Uwe Broulik

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to