----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123684/#review80104 -----------------------------------------------------------
That would make the progress bar look disabled (gray rather than blue), giving the impression the entire item isn't interactive. That's really an oversight in the QtQuick.ProgressBar that just has a MouseArea for the "hovered" property that cannot be disabled/accesse; clickable progress bars are quite rare. - Kai Uwe Broulik On Mai 8, 2015, 4:38 nachm., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123684/ > ----------------------------------------------------------- > > (Updated Mai 8, 2015, 4:38 nachm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Currently, each device notifier items are clickable which opens the file > manager or any associated apps. > In the item area, the only non clickable part is the used space progress bar, > placed at the center. > It can be problematic as users tend to click on it because of its position. > > Setting the enabled property of the ProgressBar to false will prevent click > events to be stolen from the MouseArea. > > > Diffs > ----- > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 3078cef > > Diff: https://git.reviewboard.kde.org/r/123684/diff/ > > > Testing > ------- > > Tested with mounted and umounted devices. > > > Thanks, > > Yoann Laissus > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel