----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79767 -----------------------------------------------------------
Don't remove the case that improves things for users :) src/core/global.cpp (line 394) <https://git.reviewboard.kde.org/r/123224/#comment54633> should be declared here (QString nameSuffix = ...) src/core/global.cpp (line 398) <https://git.reviewboard.kde.org/r/123224/#comment54632> oldName.mid(0) is the same as oldName. src/core/global.cpp (line 402) <https://git.reviewboard.kde.org/r/123224/#comment54634> prepend modifies the string already, no need for "nameSuffix = " src/core/global.cpp (line 412) <https://git.reviewboard.kde.org/r/123224/#comment54635> mid(0, start) is more commonly written as left(start). Same for the other mid(0, ....) above. The unittest will tell you if I'm wrong by one char, but I don't think so :) - David Faure On April 30, 2015, 9:05 a.m., Ashish Bansal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123224/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 9:05 a.m.) > > > Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. > > > Bugs: 341773 > https://bugs.kde.org/show_bug.cgi?id=341773 > > > Repository: kio > > > Description > ------- > > For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong > name(something like filename-1 2.6.tar.gz). > Expected name: filename-1.6 (1).tar.gz > > > Diffs > ----- > > autotests/globaltest.cpp ff8725d > src/core/global.cpp f18ac10 > > Diff: https://git.reviewboard.kde.org/r/123224/diff/ > > > Testing > ------- > > Works fine! > > > Thanks, > > Ashish Bansal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
