----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123539/#review79642 -----------------------------------------------------------
code looks good. desktoppackage/contents/explorer/AppletDelegate.qml (line 101) <https://git.reviewboard.kde.org/r/123539/#comment54451> it's a bit odd that we have background colour on top of the text highlight colour. Though AFAIk that combo is always garunteed to be visible.. so meh. desktoppackage/contents/explorer/AppletDelegate.qml (line 119) <https://git.reviewboard.kde.org/r/123539/#comment54450> you can also add supportsAtlasTextures: true as we're not tiling any of the sources. - David Edmundson On April 28, 2015, 6:34 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123539/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 6:34 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 342112 > https://bugs.kde.org/show_bug.cgi?id=342112 > > > Repository: plasma-desktop > > > Description > ------- > > As suggested by Andrew show a badge kind of thing with the number of running > applets inside. > > > Diffs > ----- > > desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e > > Diff: https://git.reviewboard.kde.org/r/123539/diff/ > > > Testing > ------- > > After fixing a nasty bug in the model it shows the proper number now. It also > doesn't break if you happen to have 10 or more widgets of the same kind. I > did not know what kind of font color to use. > > > File Attachments > ---------------- > > Badge in action > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg > Fancy effect in action > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
