> On April 20, 2015, 7:59 a.m., Marco Martin wrote: > > hmm, the timer is actually quite small and not bigger than the digital > > clock, It would be probably better if it stays always extended > > Bernhard Friedreich wrote: > the whole resizing mechanism of the plasmoid will need to be rewritten I > fear.. while doing this I also plan to make the timer automatically show in > it's full form also in panel. > For now (with this addition) I would leave it like it is..
what it needs is to export a sane Layout.minimumWidth / minimumHeight Like the digital clock, should export a fixed size that would make fit all numbers in the timer without continuous panel relayout. a collapsed mode may still be useful in the case of vertical, very narrow panels - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/#review79243 ----------------------------------------------------------- On April 18, 2015, 6:14 p.m., Bernhard Friedreich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123420/ > ----------------------------------------------------------- > > (Updated April 18, 2015, 6:14 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Compact Mode: shows the name of the timer and the remaining seconds > Using the tooltip it is possible to glance at the timer without > opening the full representation by clicking > > Full Mode: shows information that you can use the scroll wheel to > change the digits and choose from predefined timers using the > context menu > > BUG: 259630 > > Added missing i18n for notifaction finished text > > > Diffs > ----- > > applets/timer/package/contents/ui/timer.qml > 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 > > Diff: https://git.reviewboard.kde.org/r/123420/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Compact mode running > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png > Compact mode > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png > Full mode running > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png > Full mode > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png > Compact mode with title and time already set > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png > > > Thanks, > > Bernhard Friedreich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
