----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123426/#review79200 -----------------------------------------------------------
OK, thanks for the explanation. Will merge. - David Edmundson On April 19, 2015, 9:52 a.m., Konrad Materka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123426/ > ----------------------------------------------------------- > > (Updated April 19, 2015, 9:52 a.m.) > > > Review request for Plasma. > > > Bugs: 346002 > None > > > Description > ------- > > Fixed version of /r/123350/ > > Why VisualDelegateModel? It may be workaround/hack/you name it but it was the > only way I found acceptable. You need to pass QModelIndex to openItem and I > don't know how to get it using plain ListView and SystemModel. > VisualDelegateModel has a convenience method modelIndex which is already used > in KickoffItem.qml (but only if ApplicationsView tab is active). I changed > BaseView to use VisualDelegateModel to have modelIndex method and to be more > consistent with ApplicaitonView. > > "this change seems uneeded; we're using modelIndex fine in the old code, see > line 40 in KickoffItem.qml in the old code. > (unless maybe that didn't work ?) > My understanding is setting the model to a QAIM, internally just creates a > VDM anyway." > > It didn't work. modelIndex is used only if flag hasModelChildren is set to > true. That can happen only for ApplicationView, as only there children exist. > Also ApplicationView uses VisualDataModel explicitly, so method modelIndex is > available. > In SystemView model is set directly, VisualDataModel is not created > implicitly (or even if it is it is not accessible). In other words > listItem.ListView.view.model returns SystemModel object which is > QAbstractProxyModel/QAbstractItemModel implementation. SystemModel does not > have any slot that would be usefull in this case. > Passing "model" variable is not an option. It would be a good idea as it > contains all data related to current item but this is internal QML/Qt Quick > class. > > In KDE 4 it was not a problem as it was easy to get QModelIndex from event > (lines 860 - 878): > https://projects.kde.org/projects/kde/kde-workspace/repository/entry/plasma/desktop/applets/kickoff/ui/launcher.cpp?rev=KDE%2F4.9 > > > Diffs > ----- > > > Diff: https://git.reviewboard.kde.org/r/123426/diff/ > > > Testing > ------- > > I was able to reproduce bug using latest GIT code. > Screenshots, first shows not mounted removable device, second is error > message (in Polish): > https://www.dropbox.com/s/8vcokx17kmn3onw/zrzut%20ekranu1.png?dl=0&s=sl > https://www.dropbox.com/s/sqkci1z1fhb3h3p/zrzut%20ekranu2.png?dl=0&s=sl > > In console I can find this message: > Opening item with URL "" > > It looks that KFilePlacesModel->url(index) returns empty string for not > mounted devices. I have 5.9.0 version of libkf5kiocore5 installed. > > Patch fixed mounting. I also tested all tabs, all items works as expected. > > > File Attachments > ---------------- > > Use VisualDataModel->modelIndex in openItem > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/19/4a0d0c4d-0f76-429b-8c4a-6f9ba9856816__Bug-346002.patch > > > Thanks, > > Konrad Materka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
