----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 -----------------------------------------------------------
applets/timer/package/contents/config/main.xml (line 33) <https://git.reviewboard.kde.org/r/123332/#comment53915> Currently there's no way to set these in the UI? If there is, we'll have to migrate configs, but if can rely on them always being the current default, then there's no point. applets/timer/package/contents/ui/configAppearance.qml (line 91) <https://git.reviewboard.kde.org/r/123332/#comment53914> use Layout.fillWith: true ? - David Edmundson On April 11, 2015, 2:16 p.m., Bernhard Friedreich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123332/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 2:16 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Added config ui for specifying a title text > Added config ui for disabling the notification (default: enabled) > Added config ui for configuring the notification text > > > Diffs > ----- > > applets/timer/package/contents/config/main.xml > 886bcd413ff68b4b5b092409dbc5f0e4aff273dc > applets/timer/package/contents/ui/configAppearance.qml > ceb97326b8192a9dfe80b6753c0fd0a7e3010095 > applets/timer/package/contents/ui/timer.qml > 82fee524f51f06f522fc8c556a7454ab6840d1a3 > > Diff: https://git.reviewboard.kde.org/r/123332/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Appearance Config Ui (showing the defaults) > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png > > > Thanks, > > Bernhard Friedreich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
