----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123297/#review78679 -----------------------------------------------------------
src/plasma/pluginloader.cpp (line 256) <https://git.reviewboard.kde.org/r/123297/#comment53843> You's only using the "name" variable, why would you want to capture everything? just capture name either by value [name] or by reference [&name]. Just that one nitpick :) +1 - Mark Gaiser On apr 8, 2015, 2:48 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123297/ > ----------------------------------------------------------- > > (Updated apr 8, 2015, 2:48 p.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > This review contains two commits: > > * Look for C++ dataengines first > > These are much more common, especially in essential cases. By looking up > the plugins through KPluginLoader first, we can save querying ksycoca. > > * Use KPluginLoader to load dataengine > > KPluginLoader has all the needed machinery to identify a plugin by its > pluginId. No need to use the query parser here. > > > Diffs > ----- > > src/plasma/pluginloader.cpp a5999916b23184f939749b21007722d8ba7ffa54 > > Diff: https://git.reviewboard.kde.org/r/123297/diff/ > > > Testing > ------- > > dataengines all load correctly > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
