> On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: > > What when I place it on the desktop? I'd like it to fill the entire room > > there. If I want a massive Kickoff button on my desktop, that's up to me :) > > Martin Klapetek wrote: > +1; it should really be iff vertical == true > > Mathias Kraus wrote: > This patch adds a compact representation, so it only affects the panel. > On the desktop, you can still make it as big as you want :)
Compact representation is shown whenever the applet's size goes below the switch size, be it because it's in a panel, or because you placed it on the desktop in a small size; also an applet may choose to always collapse > On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: > > applets/kickoff/package/contents/ui/CompactRepresentation.qml, line 28 > > <https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line28> > > > > readonly property > > Mathias Kraus wrote: > The user could change the edge and then the property would also change. Read-only just means that you cannot manually assign a new value to the property potentially allowing some micro-optimization by the engine, when one the values referenced by it change it would still update - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78604 ----------------------------------------------------------- On April 7, 2015, 9:56 nachm., Mathias Kraus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123271/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 9:56 nachm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > In vertical panels, the kickoff button is huge. This patch limits the size of > the kickoff button. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123271/diff/ > > > Testing > ------- > > see screenshots > > > File Attachments > ---------------- > > kickoff-horizontal-before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png > kickoff-horizontal-after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png > kickoff-vertical-before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png > kickoff-vertical-after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png > > > Thanks, > > Mathias Kraus > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
