----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123119/#review78004 -----------------------------------------------------------
KTitleWidget also has a subtitle, no? Also pity that we cannot have that stuff styled since KTitleWidget has a border usually but just in our styles does not. src/qmlcontrols/kquickcontrols/Title.qml (line 22) <https://git.reviewboard.kde.org/r/123119/#comment53456> I thought we don't want/have icons in the title widget anymore? src/qmlcontrols/kquickcontrols/Title.qml (line 32) <https://git.reviewboard.kde.org/r/123119/#comment53457> This breaks when the user changes his font size - Kai Uwe Broulik On März 24, 2015, 3:25 nachm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123119/ > ----------------------------------------------------------- > > (Updated März 24, 2015, 3:25 nachm.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This will stick to the app's QtQuickControls theme. > > This is needed as otherwise people put PlasmaHeadings in apps which > otherwise follow the QStyle which is going to look really inconsistent. > > > Diffs > ----- > > src/qmlcontrols/kquickcontrols/Title.qml PRE-CREATION > tests/titletest.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123119/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
