> On March 19, 2015, 5:01 p.m., Harald Sitter wrote: > > FWIW I think kjobwidgets' V2 change should be reverted and instead forked > > into a V3. Otherwise KF5.9 will break ever plasma-workspace source that was > > released in the past, which is kind of the definition of a source > > incompatible change :P
This problem is fixed in the linked review - https://git.reviewboard.kde.org/r/122970/ - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123046/#review77746 ----------------------------------------------------------- On March 19, 2015, 11:16 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123046/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 11:16 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Use own copy of org.kde.JobView interface file to make it possible to extend > the interface without breaking build > (https://git.reviewboard.kde.org/r/122970/) > > This also fixes 2 cases where error/errorText would be incorrect in > applicationsjob dataengine. > > > Diffs > ----- > > dataengines/applicationjobs/CMakeLists.txt e25ff0c > dataengines/applicationjobs/jobaction.cpp f06977e > kuiserver/CMakeLists.txt a4fc049 > kuiserver/org.kde.JobView.xml PRE-CREATION > kuiserver/progresslistmodel.cpp 11fccac > > Diff: https://git.reviewboard.kde.org/r/123046/diff/ > > > Testing > ------- > > build & works fine > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
