----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122988/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-framework Description ------- Since attached properties cannot ever change during the lifetime of the object, a colorscope needs to be created for each obect that asks for the attached property. now each instance if (internal) has m_inherit (only those created as an attached property), will search for the property of the proper ancestor. Not super efficient, but the proeprties should be actually asked for rarely enough. doesn't look much nice, but seems to work pretty reliably and the only way to. Diffs ----- src/declarativeimports/core/colorscope.h fa75b9d src/declarativeimports/core/colorscope.cpp cca0d2f src/declarativeimports/plasmacomponents/qml/TabButton.qml a336900 Diff: https://git.reviewboard.kde.org/r/122988/diff/ Testing ------- Thanks, Marco Martin
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
