----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/#review77397 -----------------------------------------------------------
Ship it! Please commit to Plasma/5.2 branch and then merge into master. - Kai Uwe Broulik On März 12, 2015, 11:13 vorm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122916/ > ----------------------------------------------------------- > > (Updated März 12, 2015, 11:13 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Repeater in JobDetailsItem.qml is iterating over jobItem (JobDelegate.qml) > properties, but it only contains label0. > This patch moves the label1 + labelName1 properties from JobDetailsItem.qml > to JobDelegate.qml > > > Diffs > ----- > > applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab > applets/notifications/package/contents/ui/JobDetailsItem.qml 2f557ee > > Diff: https://git.reviewboard.kde.org/r/122916/diff/ > > > Testing > ------- > > Notifications now correctly shows both labels (in my case From and To labels > in receive files notification) > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
