----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- When job finishes, the notifications applet shows a "%job_message%: Finished" notification with action to open url (extracted from description). If the job finishes with error, this notification still displays "Finished" and offers to open url, but as the job finished with error, this url will most probably be invalid. There is also no indication that the job actually finished with error. This patch checks for job error and in case of error, set notification summary to "%job_message%: Error", body to error text and clears the actions (no open url). It only works with jobs that actually sets the error text (KJob::setErrorText), because KJob::error is not exposed in dataengine. Diffs ----- applets/notifications/package/contents/ui/Jobs.qml ee3ec5b Diff: https://git.reviewboard.kde.org/r/122921/diff/ Testing ------- Error in job is now detected, displayed in notification and there is no "open url" action. File Attachments ---------------- error-notification https://git.reviewboard.kde.org/media/uploaded/files/2015/03/12/a7f43698-8c8d-4ad3-aa03-5b527fcdc2d9__job-notification.png Thanks, David Rosca
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
