----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/#review77299 -----------------------------------------------------------
+1 looks good to me. src/kcmoduleqml.cpp <https://git.reviewboard.kde.org/r/122887/#comment53081> could you add a comment that QWidget::createWindowContainer takes ownership of the window src/kcmoduleqml_p.h <https://git.reviewboard.kde.org/r/122887/#comment53080> Q_DECL_OVERRIDE *4 - David Edmundson On March 10, 2015, 11:28 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122887/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 11:28 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kcmutils > > > Description > ------- > > This makes KCMLoader try to load the qobject-only, qml based kcms as well, if > it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it > as loaded module (the class itself is not exported, so no new symbols). > This makes systemsettings, kcmshell and any config dialog that loads kcms > transparently load those config modules not based upon KCModule > > > Diffs > ----- > > CMakeLists.txt cb4ae5d > src/CMakeLists.txt f7b869f > src/kcmoduleloader.cpp 5ccf236 > src/kcmoduleqml.cpp PRE-CREATION > src/kcmoduleqml_p.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122887/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
