> On March 1, 2015, 5:47 p.m., Aleix Pol Gonzalez wrote: > > containments/panel/contents/ui/main.qml, line 448 > > <https://git.reviewboard.kde.org/r/122766/diff/1/?file=352456#file352456line448> > > > > Maybe add a comment specifying when it will work? I've certainly seen > > this warning, never understood what is going on... > > > > Can this be removed altogether maybe?
understanding what's going on: CurrentLayout will have objects of type: appletContainmentComponent Spacers lastSpacer only appletContainmentComponent has this property. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122766/#review76819 ----------------------------------------------------------- On Feb. 28, 2015, 10:47 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122766/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 10:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > **Commit MSG:** > ``` > This prevents the following error message on plasmashell startup: > > default unknown: > file:///usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml:448: > Error: Cannot assign to non-existent property "animationsEnabled" > ``` > > > As I'm not sure what the hackery in the Timer element actually does, somebody > needs to review this before I go and commit it. > > > Diffs > ----- > > containments/panel/contents/ui/main.qml > 2772bfe934ca7a80e58953c15ed76d99c358bbbb > > Diff: https://git.reviewboard.kde.org/r/122766/diff/ > > > Testing > ------- > > - error message on plasmashell startup is gone > - animations in panel still work > > > Thanks, > > Elias Probst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
