----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122715/#review76574 -----------------------------------------------------------
Here's a rewrite which also fixes the issue: https://git.reviewboard.kde.org/r/122717/ - Sebastian Kügler On Feb. 25, 2015, 1 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122715/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 1 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > tooltip: Fix left margin in text-only tooltips > > Changelog: Fix text-only tooltips' left margin > > The approach taken is a bit ugly, since we don't have control over exact > placing due to the usage of Row and Column. The existing x and y properties > are also pretty ugly. I'm going for a spacer object and making the spacing > zero here, as that is much easier to compute than preventing from double or > triple spacing. > > I think this code needs a rewrite. This is a minimal approach to fixing the > alignment of the pager, for example. > > > Diffs > ----- > > src/declarativeimports/core/private/DefaultToolTip.qml > d1be6ae42d1c093100201dd9e20670edd6381c57 > > Diff: https://git.reviewboard.kde.org/r/122715/diff/ > > > Testing > ------- > > Tested pager individually, checked all tooltip from the panel for visual > regressions. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
