----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122695/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-framework Description ------- Filtering only by regexps is not enough because as soon as filtering by special characters is needed, they can get interpreted as regexp special characters and stuff will break. I also sense there should be a version bump of the import, but I'm unsure to what - it's 2.0 right now, should it be 2.1 or 3.0? Diffs ----- src/declarativeimports/core/datamodel.h f0a6ee2 src/declarativeimports/core/datamodel.cpp 3978556 Diff: https://git.reviewboard.kde.org/r/122695/diff/ Testing ------- Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
