-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122382/
-----------------------------------------------------------
(Updated Feb. 19, 2015, 1:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Eike Hein.
Bugs: 343333
https://bugs.kde.org/show_bug.cgi?id=343333
Repository: plasma-workspace
Description
-------
By invoking saveHistory after each change we ensure that the clipboard
doesn't lose data in case klipper (or in dataengine mode plasmashell)
crashes.
To not cause stalls, the saving is performed in a thread using
QtConcurrentRun. As klipper itself is not thread save a Mutex is
used to lock changes in the HistoryModel.
BUG: 343333
FIXED-IN: 5.3.0
Diffs
-----
klipper/klipper.h 8bb4286f39bb9855602dbe093be90e7a128c7c24
klipper/klipper.cpp 6b6d610f2ea4eda962530e2024b1b0a4da06cf7f
klipper/CMakeLists.txt 099cb712774c78faf61029e2b1c5706320010ddd
klipper/historymodel.h 78f955f0ec4b8f27dbca0573b68691be6a30e3be
klipper/historymodel.cpp 51860f6c3aca1022a2b721c27c859fc721915353
Diff: https://git.reviewboard.kde.org/r/122382/diff/
Testing
-------
looked at ~/.local/share/klipper/history2.lst in Okteta, changed clipboard and
pressed F5 in Okteta. Repeated these steps multiple times.
Thanks,
Martin Gräßlin
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
