> On Feb. 18, 2015, 4 nachm., David Edmundson wrote: > > toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml, line 42 > > <https://git.reviewboard.kde.org/r/122629/diff/1/?file=350197#file350197line42> > > > > I don't understand this comment? > > > > if you don't want it to close event.accepted = false to not eat the > > event.
I suppose it's the Escape key that is handled by the dashboard as well, it doesn't matter whether I set accepted to true or false, whenever I press Escape the dashboard closes. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122629/#review76243 ----------------------------------------------------------- On Feb. 18, 2015, 3:17 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122629/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 3:17 nachm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This turns the Column with a Repeater into a ListView by which we will get > keyboard and highlight handling for free, also add Accessible to the items. > > > Diffs > ----- > > toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 07457c3 > toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 8f91fd1 > > Diff: https://git.reviewboard.kde.org/r/122629/diff/ > > > Testing > ------- > > Using the arrow keys to navigate the menu, Return to trigger an action and > Escape to close it; looks like before. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
