----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122619/ -----------------------------------------------------------
Review request for KDE Frameworks, Plasma, Alex Richardson, David Faure, and Marco Martin. Repository: kcoreaddons Description ------- Add support for Hidden key This key does not make a lot of sense for binary plugins (those loaded from .so files which retrieve their metadata from the json-embedded data), but is useful for plugins loaded from .desktop files. This allows us to override the visibility of installed plugins by the user. I'm only considering the Hidden key here. I am not sure how the NoDisplay key (which seems to be used here and there), so maybe we should also consider NoDisplay. This is the most basic patch we can achieve the desired results with, however. Diffs ----- autotests/data/hiddenplugin.desktop PRE-CREATION autotests/kpluginmetadatatest.cpp 8a14f57dd0a8650f41185290da966f036cb66fb6 src/lib/plugin/desktopfileparser.cpp b1b5440b48e4fd412932a7d7e794d641b1406699 src/lib/plugin/kpluginmetadata.h 7ca6747c766d92be828fa3350d088a2f8b1b12f4 src/lib/plugin/kpluginmetadata.cpp cf90ebc204186f26a3199753fb8c97922a278bd1 Diff: https://git.reviewboard.kde.org/r/122619/diff/ Testing ------- * Added autotest to make sure both cases work * Tried to hide a KPackage by adding a Hidden=true to the metadata.desktop file Both work as expected with this patch. Thanks, Sebastian Kügler
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
