----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122594/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-desktop Description ------- This changes the desktop toolbox to use a Dialog and also cleans up the code a little and makes it dpi-aware (using units) Diffs ----- toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 3c26265 toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml 561eb47 toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml da153b6 toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml 26bc262 Diff: https://git.reviewboard.kde.org/r/122594/diff/ Testing ------- Positioning of the dialog is off sometimes but it just uses visualParent, so Dialog most likely needs fixing. Also the dialog cannot be toggled because when clicking outside it closes and then opens again on releasing. I don't know what magic the applet does to work around this. File Attachments ---------------- Toolbox in action https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/b84deea4-3b2f-48b6-a88c-0f3a65ae9e12__toolboxdialog.png Thanks, Kai Uwe Broulik
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
