----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122589/#review76119 -----------------------------------------------------------
Ship it! Somehow it seems to work with 2.1.4. And I agree that this is an old version (and I personally don't use VLC at all). - Martin Klapetek On Feb. 16, 2015, 11:54 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122589/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 11:54 a.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > If there was a vlc engine it got skipped due to a bug in VLC. This > bug seems to be fixed as of VLC 2.1.5 which contains the following > item in the changelog: > "dbus: Upgrade to an mpris2 compliant interface" > > Given that the workaround breaks with the fixed VLC (no media control > at all), it's better to drop it and brake VLC installations which > haven't updated for more than half a year. > > > Diffs > ----- > > dataengines/mpris2/mpris2engine.cpp > 42ca565d06b240712fbc75cfdaf7b1cc03404796 > > Diff: https://git.reviewboard.kde.org/r/122589/diff/ > > > Testing > ------- > > media controller created if VLC is running when restarting plasmashell. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
