----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122328/#review75040 -----------------------------------------------------------
I'm a bit confused. Could you first specify to which branch (master or Plasma/5.2) the patch applies ? In master at least I cannot reproduce the issue, (that is: apply does get enabled/disabled, without the patch, when config is modified) Also: the change seems unrelated: you actually remove one signal emission. Can you ellaborate on how this actually fix the issue ? - Hugo Pereira Da Costa On Jan. 30, 2015, 11:42 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122328/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 11:42 a.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > The apply button in breeze's config in windows decoration kcm wasn't becoming > active on changing the config. This fixes its behaviour. > > > Diffs > ----- > > kdecoration/config/breezeconfigwidget.cpp e160c57 > > Diff: https://git.reviewboard.kde.org/r/122328/diff/ > > > Testing > ------- > > Compiled and installed, apply button works as expected. > > > Thanks, > > Pinak Ahuja > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
