----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122171/#review75007 -----------------------------------------------------------
I noticed this got a Ship It but the original author said he had no commit access. Was this ever committed? - Luca Beltrame On Gen. 20, 2015, 3:40 p.m., Dmitry Shachnev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122171/ > ----------------------------------------------------------- > > (Updated Gen. 20, 2015, 3:40 p.m.) > > > Review request for Plasma. > > > Repository: frameworkintegration > > > Description > ------- > > Implement SystemTrayMenuItem::setMenu() correctly. > > We need to actually set the action menu, not just store it somewhere, to make > submenus in tray icons working. > > > Diffs > ----- > > src/platformtheme/kdeplatformsystemtrayicon.h 3c1bbf7 > src/platformtheme/kdeplatformsystemtrayicon.cpp d3a1d4f > > Diff: https://git.reviewboard.kde.org/r/122171/diff/ > > > Testing > ------- > > Tested this app: https://github.com/dglent/meteo-qt > > > Thanks, > > Dmitry Shachnev > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel