> On Jan. 26, 2015, 12:41 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 56 > > <https://git.reviewboard.kde.org/r/122259/diff/1/?file=345290#file345290line56> > > > > qunsetenv? > > Martin Gräßlin wrote: > see bug report: Eike explicitly suggested to set it to empty, so I went > for set empty instead of qunsetenv. As I have no way to test I do not know > whether qunsetenv would be sufficient. > > Martin Klapetek wrote: > Put a comment there, so someone else doesn't "fix" it.
I'm sorry, I didn't actually mean to be explicit about that, I was just vague -- unsetting seems to work, too. But hold on, I'll have a look at the Qt code to see if there's any attempt at fallback in there to make sure. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122259/#review74765 ----------------------------------------------------------- On Jan. 26, 2015, 12:38 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122259/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 12:38 p.m.) > > > Review request for Plasma and Eike Hein. > > > Bugs: 306932 > https://bugs.kde.org/show_bug.cgi?id=306932 > > > Repository: plasma-workspace > > > Description > ------- > > With IM modules it's possible that one cannot unlock the screen at > all. So better disable all IM modules in the greeter. > > BUG: 306932 > FIXED-IN: 5.2.1 > > > Diffs > ----- > > ksmserver/screenlocker/greeter/main.cpp > 44773631e66108e2aa1c5c6c6b97381b4a0316b2 > > Diff: https://git.reviewboard.kde.org/r/122259/diff/ > > > Testing > ------- > > compiles > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
