----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122229/#review74628 -----------------------------------------------------------
Thanks for your effort! File Attachment: Graph 1 - snapshot_J27264.png <https://git.reviewboard.kde.org//r/122229/#fcomment275> The values consistently seem to be too optimistic File Attachment: Graph 2 - chart_2.png <https://git.reviewboard.kde.org//r/122229/#fcomment276> What's that? applets/batterymonitor/package/contents/ui/batterymonitor.qml <https://git.reviewboard.kde.org/r/122229/#comment51722> Seeing this makes me really wonder why this isn't on the C++ side in PowerDevil. - Kai Uwe Broulik On Jan. 23, 2015, 7:11 nachm., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122229/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 7:11 nachm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This makes the remaining time in the battery applet much more smoother and > does not jump up and down by hours when running some short-time extensive > tasks. Whenever the battery gets below 20%, the smoothing is relaxed and the > averaged value is much more closer to the powerdevil value. > > Couple graphs showing the difference are attached. As you can see, the blue > is what powerdevil reports, the orange is the smoothed out value. The bigger > graph then also shows battery percentage for better idea. > > Obviously a 5.3 material. > > At this point I'd like to get some more data to see if we need to tweak the > alpha more. So please try out this patch, run with "plasmashell 2>&1 | grep > movingAverage" (or use your other favorite filtering way), use your laptops > casually or try also some heavy load. The output will then have all the > values and it'd be awesome if you mailed them to me directly. > > Thanks > > > Diffs > ----- > > applets/batterymonitor/package/contents/ui/batterymonitor.qml 57801a9 > > Diff: https://git.reviewboard.kde.org/r/122229/diff/ > > > Testing > ------- > > Tried running for couple days and collected quite some samples, definitely > looks better than the time jumping all over. > > > File Attachments > ---------------- > > Graph 1 > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/23/b4533731-40f3-4037-b87e-02a0888650d6__snapshot_J27264.png > Graph 2 > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/23/0634bdd1-e717-4c6b-8130-b7fabd31e068__chart_2.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
