> On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: > > applets/binary-clock/binaryclock.cpp, line 179 > > <https://git.reviewboard.kde.org/r/122196/diff/1/?file=344087#file344087line179> > > > > I think you're forgetting to actually save the config value. Look at > > the cg.writeEntry(...) calls below.
Ah, yes. Oversight on my side. Sorry for the noise. :) - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/#review74528 ----------------------------------------------------------- On Jan. 22, 2015, 12:54 p.m., Patrick Uiterwijk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122196/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 12:54 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Offer the option to show per-field binary instead of per-digit > > > Diffs > ----- > > applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 > applets/binary-clock/binaryclock.cpp > 75c4548588ff15e2316dd1c2e888ad8c07f7f78b > applets/binary-clock/clockConfig.ui > 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 > > Diff: https://git.reviewboard.kde.org/r/122196/diff/ > > > Testing > ------- > > I have compiled a patched version of kdeplasma-addons on a recent version of > Fedora (22), and am using it myself. > > > Thanks, > > Patrick Uiterwijk > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
