> On Jan. 9, 2015, 10:09 p.m., David Edmundson wrote:
> > applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml, line 2
> > <https://git.reviewboard.kde.org/r/121929/diff/1/?file=339129#file339129line2>
> >
> >     you said this was written by someone called Joshua? This looks like 
> > enthusiastic copy and paste?

Considering that file was copy+paste then modify, should I include both names? 
Also, am I meant to add my name to all the files I modified?


> On Jan. 9, 2015, 10:09 p.m., David Edmundson wrote:
> > applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml, line 33
> > <https://git.reviewboard.kde.org/r/121929/diff/1/?file=339129#file339129line33>
> >
> >     These red marks in the diff indicate spaces being left in. 
> >     
> >     ideally set your editor up to remove these, otherwise they confuse your
> >     
> >     
> >     Kate has an option under open/save -> Automatic cleanup

It seems your sentence was cut off, could you please complete it?


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121929/#review73566
-----------------------------------------------------------


On Jan. 9, 2015, 5:42 p.m., Martin Yrjölä wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121929/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 5:42 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> I posted this code review on behalf of Joshua Worth. He has ported the old 
> system load viewer style consisting of borderless bars with gradients. It 
> makes the plasmoid use less room in the panel. I have already reviewed the 
> code.
> -Martin Yrjölä
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml 
> 11550d567dac1bbe55e86793bc00adbca529aff7 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 
> 558fe6f2a01e43f5cd67498f526e1d411839beca 
>   applets/systemloadviewer/package/contents/config/main.xml 
> 89a94832595a38311c312cc4a0621b60f3aac750 
>   applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 
> PRE-CREATION 
>   
> applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml 
> dfb03e54c6702bda3d995b11c7038db2eacb94fd 
> 
> Diff: https://git.reviewboard.kde.org/r/121929/diff/
> 
> 
> Testing
> -------
> 
> Works on both desktop and panel. I didn't discover any breakage.
> -Martin Yrjölä
> 
> 
> File Attachments
> ----------------
> 
> Testing and comparison
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/01/08/b743ccc8-0955-433c-8720-1f438c4975d4__snapshot1.png
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to