> On Jan. 2, 2015, 2:55 p.m., Martin Gräßlin wrote: > > The adjustments look good to me. If we want it for the next plasma release > > I call it a "ShipIt". If we want to delay by one release the code could be > > extremely simplified by making use of > > https://git.reviewboard.kde.org/r/121667/ > > Ashish Madeti wrote: > So should I push it or wait for https://git.reviewboard.kde.org/r/121667/ > and simplify the code accordingly ?
I think this should go in, Plasma 5.2 beta date is coming up soon and that review have already missed KF5 5.6, this applet is most requested applet by users @Martin : You mean https://git.reviewboard.kde.org/r/121666/ ? or r/121667/? @Ashish : I think you should commit it for now with TODO. - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review72912 ----------------------------------------------------------- On Dec. 19, 2014, 10:53 p.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121476/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 10:53 p.m.) > > > Review request for Plasma, Bhushan Shah, Martin Gräßlin, and Vishesh Handa. > > > Repository: kdeplasma-addons > > > Description > ------- > > Ported the "Show Desktop" applet to Plasma Next. > Most of the code is derived from the old showdesktop applet. > > > Diffs > ----- > > applets/showdesktop/package/contents/config/main.xml PRE-CREATION > applets/showdesktop/package/contents/ui/main.qml PRE-CREATION > applets/showdesktop/package/metadata.desktop PRE-CREATION > applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da > applets/showdesktop/plugin/qmldir PRE-CREATION > applets/showdesktop/plugin/showdesktop.h PRE-CREATION > applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION > applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION > applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION > applets/showdesktop/showdesktop.h 5aeb848 > applets/showdesktop/showdesktop.cpp d712519 > config-kdeplasma-addons.h.cmake PRE-CREATION > CMakeLists.txt db03015 > applets/CMakeLists.txt ccd1bf7 > applets/showdesktop/CMakeLists.txt eb53207 > > Diff: https://git.reviewboard.kde.org/r/121476/diff/ > > > Testing > ------- > > Tested the applet locally, working fine. > > > Thanks, > > Ashish Madeti > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
