----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121417/#review71673 -----------------------------------------------------------
progressbar change is ok, the slider problem is caused by the issues below src/declarativeimports/plasmastyle/SliderStyle.qml <https://git.reviewboard.kde.org/r/121417/#comment49982> this is not the correct way to compute the implicit size: there is no element called "groove" src/declarativeimports/plasmastyle/SliderStyle.qml <https://git.reviewboard.kde.org/r/121417/#comment49983> height: implicitHeight * Math.floor(units.devicePixelRatio) is supposed to work (and if it doesn't, is framesvg to be fixed, not to be worked around) - Marco Martin On Dec. 9, 2014, 9:31 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121417/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 9:31 p.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > The progress bar is most likely a porting oversight when moving to the > plasmastyle, the slider's thickness is now also fixed. > > > Diffs > ----- > > src/declarativeimports/plasmastyle/ProgressBarStyle.qml 009e580 > src/declarativeimports/plasmastyle/SliderStyle.qml aeedfcf > > Diff: https://git.reviewboard.kde.org/r/121417/diff/ > > > Testing > ------- > > There's an issue with the slider's framesvg but that's unrelated to this > patch - if you look closely on the Before screenshot you can see the corners > folded inward too. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/8462eb8a-7ab5-40fd-b4d0-2c64c934b5c6__batterydevicepixelbefore.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/0cb90281-a1bf-4e38-8ae0-0fa1e06c2433__batterydevicepixelafter.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
