> On Dec. 9, 2014, 11:52 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 40 > > <https://git.reviewboard.kde.org/r/121402/diff/1/?file=332325#file332325line40> > > > > if (status === Image.Error) > > > > You also might want to avoid an endless loop when the default wallpaper > > failed too
It's not an endless loop. custom wallpaper source = wallpaper *load fail* onStatusChanged: - image.source = defaultWallpaper *load fail* onStatusChanged - image.source = defaultWallpaper This is a no-op, source is already defaultWallpaper. So this call just does nothing and we won't try reloading. (I thought the same thing when I first wrote it and had to test it) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71621 ----------------------------------------------------------- On Dec. 9, 2014, 10:56 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121402/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 10:56 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Allow user to customise wallpaper used in the lock screen. > > Nothing very fancy it's the same plain image approach we use in SDDM. > Default behaviour is unchanged. We can always expand it later. > > > Diffs > ----- > > lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 > ksmserver/screenlocker/kcm/CMakeLists.txt a23a0fc > ksmserver/screenlocker/kcm/kcm.cpp 0f74c45 > ksmserver/screenlocker/kcm/kcm.ui c891cc9 > ksmserver/screenlocker/kcm/selectimagebutton.h PRE-CREATION > ksmserver/screenlocker/kcm/selectimagebutton.cpp PRE-CREATION > ksmserver/screenlocker/greeter/greeterapp.cpp 60bd347 > ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 5207615 > > Diff: https://git.reviewboard.kde.org/r/121402/diff/ > > > Testing > ------- > > Opened lockscreen. > Most code is tried and tested in the SDDM KCM. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
