----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121398/#review71612 -----------------------------------------------------------
I think this means we can kill a bit more. But +1 to everything that is in this diff. kcms/knotify/knotify.cpp <https://git.reviewboard.kde.org/r/121398/#comment49935> then we don't need this if we only have one tab? - David Edmundson On Dec. 8, 2014, 10:55 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121398/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 10:55 p.m.) > > > Review request for Plasma, David Edmundson and Martin Klapetek. > > > Repository: plasma-desktop > > > Description > ------- > > knotifications does not obey this setting > > > Diffs > ----- > > kcms/knotify/CMakeLists.txt 333474d > kcms/knotify/knotify.h fc73b75 > kcms/knotify/knotify.cpp b05c011 > > Diff: https://git.reviewboard.kde.org/r/121398/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
