> On Nov. 25, 2014, 11:04 a.m., Aleix Pol Gonzalez wrote: > > shell/shellcorona.cpp, line 851 > > <https://git.reviewboard.kde.org/r/121240/diff/1/?file=329712#file329712line851> > > > > Are you sure this is not needed anymore? > > Daniel Vrátil wrote: > ShellCorona is not a public class, so nothing outside plasma-workspace > needs it, and the rest of plasma-workspace compiles just fine without it.
should be fine removing it, yes - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121240/#review70906 ----------------------------------------------------------- On Nov. 25, 2014, 9:18 a.m., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121240/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 9:18 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This patch ports ShellCorona and PanelView to new KScreen API. The new API is > completely asynchronous and is using shared pointers. The internals have also > undergone some major changes, but they don't directly affect Plasma. > > Additionally to the port, this patch also changes the way ShellCorona reacts > to primary screen changes: instead of listening to Output::isPrimaryChanged > on each output, it listens now to Config::primaryOutputChanged. The reason is > that when some output is set as primary, the signal is emitted right away. > This can happen before the old primary is unset though, which then causes > crashes in screenInvariants() in some situations/configurations. Listening to > Config::primaryOutputChanges ensures that Plasma reacts only once, and only > when the Config is consistent. > > The new KScreen API is available in dev/redesign branches in libkscreen.git. > I'll merge the branch to "frameworks" branch once this review is approved in > order not to break build. > > > Diffs > ----- > > shell/panelview.cpp 0dc5740 > shell/shellcorona.h 5e97e02 > shell/shellcorona.cpp 0da789f > > Diff: https://git.reviewboard.kde.org/r/121240/diff/ > > > Testing > ------- > > Been using this patch and the new KScreen for couple weeks now, works better > than the old one. > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
