----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121228/#review70905 -----------------------------------------------------------
Ship it! Ship It! - Martin Klapetek On Nov. 24, 2014, 4:29 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121228/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 4:29 p.m.) > > > Review request for Plasma, Martin Klapetek and Vishesh Handa. > > > Bugs: 341218 > https://bugs.kde.org/show_bug.cgi?id=341218 > > > Repository: plasma-workspace > > > Description > ------- > > This changes the bahavior from Math.max(icon, text + margins) to > Math.max(icon, text) + margins which should fix the layout in case the > notification has no bodytext. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationItem.qml 1074e63 > > Diff: https://git.reviewboard.kde.org/r/121228/diff/ > > > Testing > ------- > > Nope, no 5 here, hence the RR :) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
