----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121239/#review70888 -----------------------------------------------------------
Ship it! CMakeLists.txt <https://git.reviewboard.kde.org/r/121239/#comment49556> Maybe if(KF5WindowSystem_VERSION VERSION_GREATER 5.5)? ktouchpadenabler/ktouchpadenabler_daemon.cpp <https://git.reviewboard.kde.org/r/121239/#comment49555> weird indentation? =.=' Thanks! - Aleix Pol Gonzalez On Nov. 25, 2014, 12:12 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121239/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 12:12 a.m.) > > > Review request for Plasma, Aleix Pol Gonzalez and David Edmundson. > > > Repository: plasma-desktop > > > Description > ------- > > Unless used with kwindowsystem 5.5 it won't work (but will still compile) > Unless used with "a really new Qt" (i.e. when > https://codereview.qt-project.org/#/c/100200/ finally integrates) the system > settings kcm will say "ΒΆ?" instead of "Touchpad Toggle" (but it will work > just fine) > > > Diffs > ----- > > CMakeLists.txt 6612aa4 > ktouchpadenabler/CMakeLists.txt 1e46605 > ktouchpadenabler/ktouchpadenabler_daemon.cpp 9cab81b > ktouchpadenabler/settings.kcfgc 9e49060 > > Diff: https://git.reviewboard.kde.org/r/121239/diff/ > > > Testing > ------- > > Works for me. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
