> On Nov. 17, 2014, 8:37 nachm., Martin Klapetek wrote: > > applets/notifications/package/contents/ui/Notifications.qml, line 48 > > <https://git.reviewboard.kde.org/r/121155/diff/1/?file=328915#file328915line48> > > > > Would this be faster on the c++ side (the dataengine)? We should move > > it there if so. > > > > Also, does StyledText/RichText not handle \n as line breaks? > > Kai Uwe Broulik wrote: > Yeah, right, dataengine should be it. > > No, StyledText solely uses <br> for line breaks. > > I just found that KMail for example does not escape & in subjects which > makes Text just cut off(!) the message there. Meh, all of this stupid > braindead markup stuff is killing me :(
But then KMail is a 4.x application, & in text are evil anyway, and we have plenty of time to look after broken clients :) - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/#review70537 ----------------------------------------------------------- On Nov. 17, 2014, 7:40 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121155/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 7:40 nachm.) > > > Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek. > > > Bugs: 341029 > https://bugs.kde.org/show_bug.cgi?id=341029 > > > Repository: plasma-workspace > > > Description > ------- > > According to the notification spec, the body is a subset of HTML which > implies that the client has to take care of escaping things that look like > tags. To not break legacy clients that just use plain text and line breaks, > and since the spec says "each line is a paragraph" a <br> is added for each > line break instead. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationDelegate.qml faa49b1 > applets/notifications/package/contents/ui/NotificationPopup.qml 743af44 > applets/notifications/package/contents/ui/Notifications.qml 4312774 > > Diff: https://git.reviewboard.kde.org/r/121155/diff/ > > > Testing > ------- > > Tested using kdialog and knotificationdbustest and didn't find anything > unusual, needs testing with Konversation and other IRC clients that tend to > show things like <user> said something. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
