----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121133/#review70416 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Nov. 15, 2014, 8:54 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121133/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 8:54 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Warnings where > > > file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:95:29: > QML Text: Cannot anchor to an item that isn't a parent or sibling. > file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:77:33: > Unable to assign [undefined] to QUrl > file:///usr/share/plasma/kcms/kcm_splashscreen/contents/ui/main.qml:95:29: > QML Text: Cannot anchor to an item that isn't a parent or sibling. > > Since anchoring to non parent/sibling doesn't do anything i've just removed > the anchoring. > I've fixed the undefined by adding || "" > > > Diffs > ----- > > kcms/splash/package/contents/ui/main.qml 9c8fed0 > > Diff: https://git.reviewboard.kde.org/r/121133/diff/ > > > Testing > ------- > > Warnings are gone, dialog looks the same. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
