----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121114/#review70352 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 13, 2014, 8:26 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121114/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 8:26 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Add Q_PLUGIN_METADATA so the attica_kde.so plugin can be loaded by > QPluginLoader. > > > Diffs > ----- > > attica-kde/kdeplugin/kdeplatformdependent.h > 69883dba4d24567a4787ebc8217beab0723891ea > > Diff: https://git.reviewboard.kde.org/r/121114/diff/ > > > Testing > ------- > > Before this attica would try to load the plugin (if it was installed in the > right place, I've another attica patch to fix that) but failed because > QPluginLoader::instance() would return null without this. > > Now it works (with my attica patch) > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
