----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121085/#review70121 -----------------------------------------------------------
src/declarativeimports/plasmacomponents/qml/styles/ProgressBarStyle.qml <https://git.reviewboard.kde.org/r/121085/#comment49069> Given it just rotates the progress bar in vertical mode, this breaks the custom styling. I would need to rotate our item in the opposite direction to provide custom theming shooting down the comfort Qt gives us by auto-sizing the item src/declarativeimports/plasmacomponents/qml/styles/ProgressBarStyle.qml <https://git.reviewboard.kde.org/r/121085/#comment49070> Forgot the Math.max(svg margins, ...) - Kai Uwe Broulik On Nov. 9, 2014, 4:18 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121085/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2014, 4:18 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This also fixes a regression introduced in > 7a5342e97067cffb316fd57e20f1ca326a0854ee where the devicePixelRatio was no > longer taken into account. > > The test is enhanced to also cover vertical bars. The QtQuick.Controls > ProgressBar just rotates the progress bar by 90° when vertical so I could > remove a lot of the (vertical ? foo : bar) everywhere. > > I tried to migrate the indeterminate animation to Animators but after > thinking about adding timers and having a dozen of bindings to reset the > animation I stopped. > > > Diffs > ----- > > tests/components/progressbar.qml 7098650 > src/declarativeimports/plasmacomponents/qml/styles/ProgressBarStyle.qml > PRE-CREATION > src/declarativeimports/plasmacomponents/qml/ProgressBar.qml 69b6df1 > > Diff: https://git.reviewboard.kde.org/r/121085/diff/ > > > Testing > ------- > > Battery monitor looks like it did before, used the progressbar test to spot > regressions. > > The only regression I found was that > minimumValue: -100 > maximumValue: 100 > value: 0 > yields an empty 0% bar instead, value: 50 a 50%, seems minimumValue cannot go > below 0? > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
