> On Nov. 3, 2014, 2:51 a.m., Marco Martin wrote: > > looks a bit overkill?
Marco, Can you be more specific? which bit is overkill? - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69718 ----------------------------------------------------------- On Nov. 2, 2014, 3:09 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120949/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2014, 3:09 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now, > but need to come from the qml. This is a first attempt posting to get > feedback about the approach etc. > > > Diffs > ----- > > applets/fifteenPuzzle/package/contents/config/main.xml > 0dd804a12ddb0c7c2daaced1b92582f0deff494f > applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml > bf9581bd78c1c7690fc16f01e440adad0fc98766 > applets/fifteenPuzzle/package/contents/ui/Piece.qml > c386570aebdf4323e3132aa05445b38383149dea > applets/fifteenPuzzle/package/contents/ui/configAppearance.qml > d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 > applets/fifteenPuzzle/package/contents/ui/main.qml > c76eaeb4d936fe917d99375722905c2f002c33e6 > applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION > applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION > applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION > applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION > applets/fifteenPuzzle/plugin/qmldir PRE-CREATION > applets/fifteenPuzzle/CMakeLists.txt > c7e6a718a6211e0cde1121609ed28ec0fe8448f7 > > Diff: https://git.reviewboard.kde.org/r/120949/diff/ > > > Testing > ------- > > It builds and runs, currently doesn't shuffle, to test the result image works > and appears. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
