-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 8:26 nachm.)
Review request for Plasma and Martin Klapetek.
Changes
-------
- No more links in titles, clients that require that are broken
- Bind item to notificationProperties directly instead of assigning each
property
- Remove explicit StyledText, Qt figures that out by itself (fixes KMail) and
it never resorts to RichText (which was my initial reason for this) by itself
- Re-order properties for better readability
- Restored timer stuff in containsMouseChanged
- No longer vertically align icon (I like it better, especially for the smaller
popups which are the majority but outside the scope of this patch, sorry for
that)
- Added history screenshot
Repository: plasma-workspace
Description
-------
This moves duplicate code (notification icon, heading, text, action buttons)
into a separate NotificationItem {} component used by both the notification
popup as well as the notification list delegate.
If we ever were to provide richer notifications for specific usecases (you can
provide custom hints in notifications after all) this would ease this and less
duplication is always good :)
I also cleaned up a bit of commented/unused code and changed complicated
anchoring to QtQuick Layouts where applicable.
Diffs (updated)
-----
applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2
applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION
applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2
Diff: https://git.reviewboard.kde.org/r/120943/diff/
Testing
-------
Ran knotificationdbustest and didn't notice anything unusual, visually the
thing should look and behave exactly like it did before. Additional testing is
welcomed, however.
File Attachments (updated)
----------------
New popup
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
New history
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/03/e7efdf8f-09de-4eaf-a7a2-d37979bad28b__newnotificationhistory.png
Thanks,
Kai Uwe Broulik
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
