> On Oct. 28, 2014, 5:26 p.m., Marco Martin wrote:
> > Still related to the comment of the previous review request..
> > If the l&f package actually provides the qml files of the switcher, kindof 
> > removes the point of the defaults file...
> > or is it still possible to set a different switcxher in the kwin config?
> > in this case this patch is fine, provided all the other switchers to be in 
> > the same package format

> or is it still possible to set a different switcxher in the kwin config?

yes. Though the configuration module needs adjustment. That it's still possible 
to configure another switcher can be seen in 
https://git.reviewboard.kde.org/r/120849/


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120850/#review69304
-----------------------------------------------------------


On Oct. 28, 2014, 4:55 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120850/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 4:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Move KWin's window switcher "sidebar" to Look'n'Feel package
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b 
>   lookandfeel/contents/windowswitcher/WindowSwitcher.qml 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
> 
> Diff: https://git.reviewboard.kde.org/r/120850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to