----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120602/#review68516 -----------------------------------------------------------
Ship it! the patch is ok, however the fact that if a mainITem is not explicitly set the behavior is different reveals some weird underlying problem. (it's the default property, *should* be the same) - Marco Martin On Ott. 15, 2014, 8:23 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120602/ > ----------------------------------------------------------- > > (Updated Ott. 15, 2014, 8:23 p.m.) > > > Review request for Plasma and Marco Martin. > > > Bugs: 340003 > https://bugs.kde.org/show_bug.cgi?id=340003 > > > Repository: plasma-desktop > > > Description > ------- > > Fixes a porting oversight and also takes into account the buttons and heading. > > Apparently when a dialog does not explicitly set a mainItem, the Dialog tries > to guess the size from the children of the dialog which was anchors.fill and > then it got confused. > > > Diffs > ----- > > desktoppackage/contents/explorer/AppletAlternatives.qml 4e97dc9 > > Diff: https://git.reviewboard.kde.org/r/120602/diff/ > > > Testing > ------- > > Dialog flies in smoothly trying to display the list without scrollbars but is > still properly max'd to not fill the entire screen. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
