----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68396 -----------------------------------------------------------
src/quickaddons/imagetexturescache.h <https://git.reviewboard.kde.org/r/120550/#comment47668> Strange indentation. - Vishesh Handa On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120550/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 5:54 p.m.) > > > Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin. > > > Repository: kdeclarative > > > Description > ------- > > Moves the caching types used in Plasma Workspace into a QuickAddons submodule. > > Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter > item. Uses the same strategies used in Plasma Framework for caching the > textures. > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 > src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f > src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 > src/quickaddons/CMakeLists.txt PRE-CREATION > src/quickaddons/imagetexturescache.h PRE-CREATION > src/quickaddons/imagetexturescache.cpp PRE-CREATION > src/quickaddons/managedtexturenode.h PRE-CREATION > src/quickaddons/managedtexturenode.cpp PRE-CREATION > tests/qiconitem_test.qml PRE-CREATION > src/CMakeLists.txt eb0dfd3 > > Diff: https://git.reviewboard.kde.org/r/120550/diff/ > > > Testing > ------- > > I added some manual test (that was impossible to run before the patch). Also > tested it in KRunner and Muon Discover, which use the component. Everything > still works. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
