> On Oct. 13, 2014, 1:16 a.m., Aleix Pol Gonzalez wrote: > > Wouldn't it make sense to have this within KToolInvocation? It's > > responsible for chosing what's the default browser already. In any case we > > want it in sync.
Yes, if we always set x-scheme-handler/http, then ktoolinvocation_x11.cpp can read that instead of BrowserApplication. But that's basically compatibility the other way around (KDE apps reading the scheme-handler setting set by other environments), so that's for a separate patch (this one is about KDE workspace setting scheme-handler for non-KDE apps to see). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/#review68295 ----------------------------------------------------------- On Oct. 12, 2014, 8:40 p.m., Luc Menut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120568/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2014, 8:40 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-desktop > > > Description > ------- > > Save the default browser by writing x-scheme-handler/http and > x-scheme-handler/https into the group [Default Applications] in the file > mimeapps.list . > Nowadays, many applications look at user preferences for > x-scheme-handler/http to determine the default browser, so setting this value > would increase interoperability with these applications. > > regards, > > Luc Menut - Mageia > > PS: I don't have write access to kde git, so could you commit the change if > the patch looks fine. Thanks. > > > Diffs > ----- > > kcms/componentchooser/componentchooserbrowser.cpp 61af1fd > > Diff: https://git.reviewboard.kde.org/r/120568/diff/ > > > Testing > ------- > > > Thanks, > > Luc Menut > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
