On Sunday 12 October 2014 20:48:36 David Edmundson wrote:
> On 12 Oct 2014 18:04, "šumski" <hrvoje.sen...@gmail.com> wrote:
> > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote:
> > > > I'll report back when I've confirmed this and then we can work out
> 
> how we
> 
> > > > proceed.
> > > > 
> > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make
> > > 
> > > everything work.
> > > 
> > > Assuming we don't have a time machine our options are:
> > >  - revert this commit and release plasma-framework 5.3.1 really quickly
> > 
> > Please go with this option...

How will this affect Plasma 5.1? Given the review it looks like it was moved 
into workspace - is it a problem to have the code twice?

Anyway if you revert, please deprecate the code, add a TODO KF6 and a comment 
on why it cannot be removed. I find it kind of scary that a change in the 
private implementation detail breaks the released software.

Cheers
Martin

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to