----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120533/#review68094 -----------------------------------------------------------
Ship it! yeah, colorscheme should definitely be in general. widgetStyle (and that's what I think made the confusion at the beginning leading to wrong stuff in wrong groups all over the place) is that widgetStyle appears to be in [General] in KDE4, in [KDE] in kf5 (no idea why) patch is correct btw, i can push it tomorrow - Marco Martin On Oct. 8, 2014, 8:28 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120533/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 8:28 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Read/Write ColorScheme to configGroup General instead of KDE > > commit d59d611731e293f06ce24361aff79fb02554987f changed one of the many > places this group is used. I think it was a correct change. > > This fixes all the other places. > > > Diffs > ----- > > kcms/lookandfeel/autotests/kcmtest.cpp 83dcb40 > kcms/lookandfeel/autotests/lookandfeel/contents/defaults ebafb42 > kcms/lookandfeel/kcm.cpp 2b61412 > > Diff: https://git.reviewboard.kde.org/r/120533/diff/ > > > Testing > ------- > > Tests pass (note I had to wipe ~/.qttest as plasmapackage doesn't reinstall > if it detects the old lookandfeel package in there) > Not tested the KCM properly. > > I /think/ that WidgetStyle belongs in General rather than KDE too. My KDE4 > kdeglobals config certainly looks like that; my KF5 one has it in both > places.. probably due to this KCM so I can't really tell what's correct. > > (note I am traveling tomorrow. Marco, if this looks sensible please could you > merge it for me) > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
