----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/#review68039 -----------------------------------------------------------
shell/desktopview.h <https://git.reviewboard.kde.org/r/120516/#comment47425> don't put a NOTIFY, just a CONSTANT without signal shell/desktopview.h <https://git.reviewboard.kde.org/r/120516/#comment47426> even the setter and the internal variable is not necessary, you can just check if m_corona is a shellcorona or not - Marco Martin On Ott. 7, 2014, 4:24 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120516/ > ----------------------------------------------------------- > > (Updated Ott. 7, 2014, 4:24 a.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-workspace > > > Description > ------- > > this can be used by shell package to know if it is opened in application mode > or full shell > > > Diffs > ----- > > shell/desktopview.h 1b07261 > shell/desktopview.cpp dcd002d > shell/standaloneappcorona.cpp dd9b69b > > Diff: https://git.reviewboard.kde.org/r/120516/diff/ > > > Testing > ------- > > tested with pmc > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
